Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where providers headers was not correctly set for ClientV2. #264

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fix a bug where providers headers was not correctly set for ClientV2. #264

merged 3 commits into from
Sep 18, 2023

Conversation

MilkywayPirate
Copy link
Contributor

@MilkywayPirate MilkywayPirate commented Sep 18, 2023 •
edited
Loading

Purpose

Fix a bug that caused extra set http headers not to be included in requests for ClientV2.

Changes

Add the CallCredentials to the underlying grpc stub if a connection has extra headers set.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@MilkywayPirate MilkywayPirate merged commit 8104419 into main Sep 18, 2023
1 check passed
@MilkywayPirate MilkywayPirate deleted the headers-fix branch September 18, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilkywayPirate @abizjak